Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't display image inline when upload image and duble click it. #2450

Closed
mshayashi opened this issue Mar 30, 2018 · 1 comment
Closed

Can't display image inline when upload image and duble click it. #2450

mshayashi opened this issue Mar 30, 2018 · 1 comment
Assignees

Comments

@mshayashi
Copy link

mshayashi commented Mar 30, 2018

When I upload image and duble click the uploaded image on elFinder, content url is wrong on popup window.

  1. uploaded 17.jpg.
  2. double click uploaded 17.jpg.
  3. popup window's url is https://localhost/7.jpg

https://github.com/Studio-42/elFinder/blob/master/php/elFinderVolumeDriver.class.php
I think it should not add 1 on the source code of getContentUrl method on 2981 line.

$path = str_replace($this->separator, '/', substr($this->decode($hash), strlen($this->root) + 1));

It might be below is correct.

$path = str_replace($this->separator, '/', substr($this->decode($hash), strlen($this->root) ));

Is this a bug, or another reasons?

@nao-pon
Copy link
Member

nao-pon commented Mar 30, 2018

@mshayashi This is a bug. There is a problem when $root is "/". so I'll fix it.

Thanks! 👍

@nao-pon nao-pon self-assigned this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants