Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Folder to upload issue #2378

Closed
todhing opened this issue Feb 8, 2018 · 7 comments
Closed

Select Folder to upload issue #2378

todhing opened this issue Feb 8, 2018 · 7 comments
Assignees

Comments

@todhing
Copy link

todhing commented Feb 8, 2018

When I select a folder to upload I get inconsistent behavior. Sometimes the upload will include the folder I selected and everything below it, which is what I expect to happen. But other times, it will only select the files and folder below the main folder I selected (It does not include the top level folder name I selected). I do not see this issue when I use drag and drop. I only see the issue when I use the upload icon or select file/folder option.

@nao-pon
Copy link
Member

nao-pon commented Feb 8, 2018

@todhing I tried several patterns with Windows 10/64 bit Chrome 64 and Firefox 58, but I could not reproduce this problem.

Can you show the procedure to reproduce this problem?

@todhing
Copy link
Author

todhing commented Feb 8, 2018

studyx.zip

I have a file structure similar to the attached zip. If I try to upload any of the folders 2 or more levels deep, nothing happens. It does not upload the folder.

@nao-pon nao-pon self-assigned this Feb 9, 2018
@nao-pon
Copy link
Member

nao-pon commented Feb 9, 2018

@todhing The cause of this problem is that the directory selector does not include directories that do not contain files in the file data obtained by the directory selector.

Since elFinder does not support such data, there is a bug that nothing happens. I will fix this, but the directory which does not contain the file will be skipped and uploaded.

@todhing
Copy link
Author

todhing commented Feb 9, 2018

But if the folder below it has files it still does not upload. I would think that it would check for files in the sub-directories as well.

@nao-pon nao-pon closed this as completed in 20518b7 Feb 9, 2018
@nao-pon
Copy link
Member

nao-pon commented Feb 9, 2018

@todhing I fixed this issue. Please try nightly build. so please don't forget browser cache clearing.

@nao-pon
Copy link
Member

nao-pon commented Feb 9, 2018

Chrome has a related bug. - Webkitdirectory input returns wrong path of selected files

@todhing
Copy link
Author

todhing commented Feb 13, 2018

@nao-pon I tested the new build and it does fix one of the issues. However, if you test with the zip file here, you will notice that when you try to upload folder subject05 or subject06, It will start with the "hurdle" subfolder. It should start with subject05 or subject06. It works as expected when uploading subject16.

subject.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants