Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve trash feature #1991

Closed
CodeLyokoXtEAM opened this issue May 2, 2017 · 3 comments
Closed

Improve trash feature #1991

CodeLyokoXtEAM opened this issue May 2, 2017 · 3 comments
Assignees
Labels

Comments

@CodeLyokoXtEAM
Copy link
Contributor

CodeLyokoXtEAM commented May 2, 2017

Finally its working☺☺☺

  1. massage box for confirm move files to trash or delete it.
  2. I saw that inside of trash you can create new folders (its unnecessary).
  3. Copy function is unnecessary & it's function to restore & cut (use fix folder structure to restore it).
@nao-pon nao-pon closed this as completed in 2c5453a May 3, 2017
@nao-pon
Copy link
Member

nao-pon commented May 3, 2017

@CodeLyokoXtEAM

  1. You can delete it without going through the trash by Ctrl + Delete or Delete icon in the context menu.
  2. It is necessary to remember the folder tree.
  3. I implemented the restore function. In Trash Volume, the copy command is replaced with the restore command. Also, the cut command is left for when the restore destination can not be detected.

Thanks!

@nao-pon nao-pon self-assigned this May 3, 2017
@nao-pon nao-pon added the feature label May 3, 2017
@CodeLyokoXtEAM
Copy link
Contributor Author

CodeLyokoXtEAM commented May 3, 2017

there is little bugs in drag & drop.

  1. user can drag & drop file into any path in trash.(but only this happen first or second drag & drop)
    I think user drag file any path in trash that file must go to original deleted path.

image

  1. also press 'ctrl' & drag file to trash it not deleted & copy file to trash.

image

@nao-pon
Copy link
Member

nao-pon commented May 4, 2017

OK, Try to disable dropping in the trash.

nao-pon added a commit that referenced this issue May 4, 2017
Disable only those that are replaced by the `hidden` command

c.f. #1991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants