Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty dialog on elfinder load #1824

Closed
jhon100 opened this issue Dec 23, 2016 · 9 comments
Closed

Empty dialog on elfinder load #1824

jhon100 opened this issue Dec 23, 2016 · 9 comments
Assignees

Comments

@jhon100
Copy link

jhon100 commented Dec 23, 2016

I'm not sure if the problem is related with the change made in #1814 , because before that I was using version 2.1.18, but after I updated to

https://github.com/Studio-42/elFinder/tree/42002388bc6f64c56daedb3e95ebdf9bbd946cec#downloads >
elFinder 2.1.x (Nightly)

Some times on load, an empty dialog appear in elfinder area.
elfinder

Is not easy to reproduce the error as it occur very randomly. Most of the time the empty dialog does not appear.

The markup of the empty dialog is this:

<div class="ui-front ui-dialog ui-widget ui-widget-content ui-corner-all ui-draggable std42-dialog touch-punch elfinder-dialog elfinder-dialog-notify" style="width: 280px; height: auto; top: 58px; right: auto; position: absolute; opacity: 0.75; bottom: auto; left: 499px;">
    <div class="ui-dialog-titlebar ui-widget-header ui-corner-all ui-helper-clearfix">
        <span class="ui-widget-header ui-dialog-titlebar-close ui-corner-all elfinder-titlebar-button elfinder-titlebar-button-right">
            <span class="ui-icon ui-icon-closethick"></span>
        </span>
        <span class="elfinder-dialog-title">&nbsp;</span>
    </div>
    <div class="ui-dialog-content ui-widget-content"></div>
</div>
@jhon100
Copy link
Author

jhon100 commented Dec 23, 2016

Here the image with default theme
elfinder

@nao-pon
Copy link
Member

nao-pon commented Dec 27, 2016

I can not reproduce such a problem. Is there a similar problem even if elFinder is used standalone?

@jhon100
Copy link
Author

jhon100 commented Dec 27, 2016

@nao-pon, I found that the error occur only when the elfinder container is initially hidden. In my case I'm using elfinder inside bootstrap collapse but you can reproduce the error setting the elfinder container display property to none and change it in browser developer console.

I don't know why but you will reproduce the error more easily with a fresh opened browser. In this way the error always occur but if other tabs or windows of the same browser are opened the error occur very randomly.

@nao-pon
Copy link
Member

nao-pon commented Dec 28, 2016

you can reproduce the error setting the elfinder container display property to none and change it in browser developer console.

I can't see yet that error. -> online test case and output for check

@jhon100
Copy link
Author

jhon100 commented Dec 28, 2016

I tried both versions and the error happened:

capturar2

If you click in the button while elfinder is 'loading' (with a dialog 'open folder' and progress bar visible) no error occur. You will see the error if you click the button after elfinder is loaded. Try wait about 5 seconds before clicking...

@nao-pon
Copy link
Member

nao-pon commented Dec 28, 2016

Umm... I can't see yet. I tested like this.
wrongdialogtest

@jhon100
Copy link
Author

jhon100 commented Dec 28, 2016

With a small width as in your capture I had dificulty to reproduce the error too. Try with this link: http://output.jsbin.com/kowuqi.

22

As you can see in my capture, instead of waiting about 5 seconds you can monitore when the ajax call ends, so you can click,

It seems the problem is related with the initial 'loading' dialog header not being removed if the container is hidden. In my capture you see that if I change to a folder that takes a long time to load and you hide elfinder before the loading is complete, when click to show elfinder (after the folder is loaded) the empty dialog appear.

@nao-pon
Copy link
Member

nao-pon commented Dec 28, 2016

@jhon100 OK, I got it! You are right so I'll fix it. Please wait until fix it. Thanks!

@nao-pon nao-pon self-assigned this Dec 28, 2016
@jhon100
Copy link
Author

jhon100 commented Dec 28, 2016

Thanks a lot @nao-pon .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants