Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to upload .zip (.mcworld) files #52

Open
janzen01 opened this issue Dec 16, 2020 · 14 comments · May be fixed by #53
Open

Unable to upload .zip (.mcworld) files #52

janzen01 opened this issue Dec 16, 2020 · 14 comments · May be fixed by #53
Assignees
Labels
priority Priority or time-sensitive issue problem Problem that needs to be fixed

Comments

@janzen01
Copy link
Member

Hi, due to a problem discovered on Monday, I wanted to upload all the materials we have to the blog. Unfortunately, the blog does not accept .zip and .mcworld files for me. It reports an error during the check :(

image
Lumen Energetická výzva.zip

@Vilican Vilican added priority Priority or time-sensitive issue problem Problem that needs to be fixed labels Dec 16, 2020
@Vilican Vilican pinned this issue Dec 16, 2020
@Vilican
Copy link
Member

Vilican commented Dec 16, 2020

My recent commits did not fix that issue. Need someone to look further into this.

@petrkucerak
Copy link
Member

@janzen01 I tested it and found out:

If you upload file in text editor, it causes error but if you upload file in special section in wp for uploading medias, everything is clear.
So, I recommend you use second options in this moment and after we will fix it, I will let you know.

image

@filiptronicek
Copy link

Interesting seems like the problem could arise from the API between the media library and the server? Will look further at how different these are. @petrkucerak

@petrkucerak
Copy link
Member

Please @petrkucerak test all plugins from blog

@Vilican Vilican linked a pull request Feb 19, 2021 that will close this issue
@Elesaa
Copy link

Elesaa commented Mar 21, 2021

Any update on this? @petrkucerak your solution you showed here is not working.

@petrkucerak
Copy link
Member

Notes from testing vol 1

Team @filiptronicek @kahy9

Uploading zip files
955 kB - Pass
7.04 MB - Error
3.01 MB - Error
2.03 MB - Error
1.89 MB - Pass
1.97 MB - Pass
2.00 MB - Error
1.99 MB - Pass
=> border is 2 MB

@petrkucerak
Copy link
Member

hosting --;
we tested it on other wedos hostings

@filiptronicek
Copy link

filiptronicek commented Mar 24, 2021

We have now established that this is most likely due to the unfiltered_upload permission in WordPress, which only admins by default have.

@filiptronicek
Copy link

filiptronicek commented Mar 24, 2021

Ok, not so quick. We have checked by adding this permission to a user (me) and I still had the same error.
Specified file failed upload test

@filiptronicek
Copy link

filiptronicek commented Mar 24, 2021

A quick summary from testing today: (with @petrkucerak & @kahy9 )

  1. It looks like a permission problem - not sure which permission, but one of them, probably, who knows.
  2. It could be due to the firewall security rules assigning a less regulated list of actions to admins.
  3. It could be a plugin error, but the error appears only on users with the absent Administrator role.
  4. It is a core error, raised by wp-admin/includes/file.php here:
// A properly uploaded file will pass this test. There should be no reason to override this one.
$test_uploaded_file = 'wp_handle_upload' === $action ? is_uploaded_file($file['tmp_name']) : @is_readable($file['tmp_name']);
  1. We tested this on different hosts (including the same) and we couldn't reproduce the issue with any built-in user roles.
  2. The upload limit is (for non-admin users) 2MB. (1.99MB will pass)
  3. It could be caused by Wordpress making multiple file chunks each being 2MB in size.

@petrkucerak petrkucerak added this to the Week 4/19/2021 milestone Apr 21, 2021
@petrkucerak
Copy link
Member

petrkucerak commented May 5, 2021

Notions for a discussion :

@petrkucerak petrkucerak modified the milestones: Week 4/19/2021, Week 19/05/2021 May 5, 2021
@Vilican Vilican removed this from the Week 19/05/2021 milestone Jul 13, 2021
@janzen01
Copy link
Member Author

janzen01 commented May 8, 2022

@petrkucerak This problem happened again with this file:
Science Island 2021 - BBTNB.zip

I would be very happy if the problem will be fixed soon.

@filiptronicek filiptronicek removed their assignment Sep 26, 2022
@petrkucerak petrkucerak removed their assignment Feb 2, 2023
@petrkucerak petrkucerak unpinned this issue Aug 17, 2023
@Vilican Vilican pinned this issue Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Priority or time-sensitive issue problem Problem that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants