Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a process for merging with the three.js version? #33

Open
bplu4t2f opened this issue May 4, 2023 · 0 comments
Open

Is there a process for merging with the three.js version? #33

bplu4t2f opened this issue May 4, 2023 · 0 comments

Comments

@bplu4t2f
Copy link

bplu4t2f commented May 4, 2023

I noticed that the version of the CSM code which is distributed with three.js (as an addon) is very out of date and contains at least one "showstopper" bug which has been fixed in this repo long ago.

There are quite a lot of other differences too.

Merging is not entirely trivial so I'm reluctant to do it manually, and I've not seen any automation in this regard.

Last but not least, due to the unfortunate shader injection situation, the shader code in this repo also needs to be updated because the light_fragment_begin shader code has had updates which have not been merged into this repo yet.

Do you have any stance on this? Are there any plans or strategies in play to keep the versions from diverging? Can we improve the situation somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant