Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support invoking current-version goal via cli #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions src/it/current-version-cli/pom.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright (c) 2018 RedEngine Ltd, http://www.redengine.co.nz. All rights reserved. -->
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>net.stickycode.plugins.it</groupId>
<artifactId>sticky-bounds-plugin-current-version-cli</artifactId>
<version>1.1-SNAPSHOT</version>
<packaging>pom</packaging>

<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>3.1.0</version>
<executions>
<execution>
<phase>test</phase>
<goals>
<goal>exec</goal>
</goals>
</execution>
</executions>
<configuration>
<executable>mvn</executable>
<arguments>
<argument>net.stickycode.plugins:bounds-maven-plugin:@pom.version@:current-version</argument>
<argument>-Dartifact=net.stickycode:sticky-coercion:[2,3)</argument>
</arguments>
</configuration>
</plugin>
</plugins>
</build>
</project>
23 changes: 23 additions & 0 deletions src/it/current-version-cli/verify.bsh
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import java.io.*;
import java.util.*;

import org.codehaus.plexus.util.*;

File buildLog = new File( basedir, "build.log" );
System.out.println( "Checking for existence of first test file: " + buildLog );
if (!buildLog.exists())
throw new RuntimeException(buildLog.toString() + " not found" );

String logs = FileUtils.fileRead( buildLog, "UTF-8" ).trim();

if (!logs.contains("exec-maven-plugin")) {
System.err.println("Expected to invoke exec-maven-plugin");
return false;
}

if (!logs.contains("resolved net.stickycode:sticky-coercion:jar:[2,3) to 2.7")) {
System.err.println("Expected version to be 2.7");
return false;
}

return true;
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ public class StickyCurrentVersionMojo

@Parameter(required = false)
private Map<String, String> coordinates;

/**
* Useful when using the maven cli to look up the current version of a single artifact. Version range is
* supported since the property is not split into a list.
*/
@Parameter(required = false, property = "artifact")
private String artifact;
Comment on lines +38 to +43
Copy link
Author

@wade-taylor wade-taylor Jul 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a parameter for a singular artifact allows you to get around maven mis-interpreting the comma in a version range.

For comparison, we could change the artifacts parameter to:

@Parameter(required=false, property="artifacts")
private List<String> artifacts;

which would allow us to set it on the command line via

-Dartifacts=org.apache.commons:commons-lang3:[3,4)

However, maven will mangle the comma in the version range and interpret this a 2 artifacts:

  1. org.apache.commons:commons-lang3:[3
  2. 4)
    which obviously is not what's intended.


/**
* The artifacts to get the current version for group:artifact:version
Expand All @@ -56,9 +63,11 @@ public class StickyCurrentVersionMojo
@Override
public void execute()
throws MojoExecutionException, MojoFailureException {

List<ArtifactLookup> lookup = new ArrayList<>();

if (this.artifact != null)
lookup.add(new ArtifactLookup().withGav(this.artifact));

if (artifacts != null)
for (String artifact : artifacts) {
lookup.add(new ArtifactLookup().withGav(artifact));
Expand Down