-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support invoking current-version goal via cli #16
Open
wade-taylor
wants to merge
1
commit into
StickySource:master
Choose a base branch
from
wade-taylor:current-version-cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!-- Copyright (c) 2018 RedEngine Ltd, http://www.redengine.co.nz. All rights reserved. --> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
|
||
<groupId>net.stickycode.plugins.it</groupId> | ||
<artifactId>sticky-bounds-plugin-current-version-cli</artifactId> | ||
<version>1.1-SNAPSHOT</version> | ||
<packaging>pom</packaging> | ||
|
||
<build> | ||
<plugins> | ||
<plugin> | ||
<groupId>org.codehaus.mojo</groupId> | ||
<artifactId>exec-maven-plugin</artifactId> | ||
<version>3.1.0</version> | ||
<executions> | ||
<execution> | ||
<phase>test</phase> | ||
<goals> | ||
<goal>exec</goal> | ||
</goals> | ||
</execution> | ||
</executions> | ||
<configuration> | ||
<executable>mvn</executable> | ||
<arguments> | ||
<argument>net.stickycode.plugins:bounds-maven-plugin:@pom.version@:current-version</argument> | ||
<argument>-Dartifact=net.stickycode:sticky-coercion:[2,3)</argument> | ||
</arguments> | ||
</configuration> | ||
</plugin> | ||
</plugins> | ||
</build> | ||
</project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import java.io.*; | ||
import java.util.*; | ||
|
||
import org.codehaus.plexus.util.*; | ||
|
||
File buildLog = new File( basedir, "build.log" ); | ||
System.out.println( "Checking for existence of first test file: " + buildLog ); | ||
if (!buildLog.exists()) | ||
throw new RuntimeException(buildLog.toString() + " not found" ); | ||
|
||
String logs = FileUtils.fileRead( buildLog, "UTF-8" ).trim(); | ||
|
||
if (!logs.contains("exec-maven-plugin")) { | ||
System.err.println("Expected to invoke exec-maven-plugin"); | ||
return false; | ||
} | ||
|
||
if (!logs.contains("resolved net.stickycode:sticky-coercion:jar:[2,3) to 2.7")) { | ||
System.err.println("Expected version to be 2.7"); | ||
return false; | ||
} | ||
|
||
return true; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a parameter for a singular artifact allows you to get around maven mis-interpreting the comma in a version range.
For comparison, we could change the
artifacts
parameter to:which would allow us to set it on the command line via
However, maven will mangle the comma in the version range and interpret this a 2 artifacts:
org.apache.commons:commons-lang3:[3
4)
which obviously is not what's intended.