Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove coingecko package and replace with async methods #511

Closed
StephanAkkerman opened this issue Feb 22, 2024 · 2 comments
Closed

Remove coingecko package and replace with async methods #511

StephanAkkerman opened this issue Feb 22, 2024 · 2 comments
Labels
Difficulty: Medium 😐 This issue can be solved, but a decent amount of lines need to be changed Improvement 📈 Improvement Overhaul 🌈 Overhaul a part of the code Priority: High 🥇 Assign this label if this issue is VERY important or often used

Comments

@StephanAkkerman
Copy link
Owner

StephanAkkerman commented Feb 22, 2024 •
edited
Loading

We can just call the API ourselves using the aiohttp method, this will make it quicker (hopefully).
@StephanAkkerman StephanAkkerman added Improvement 📈 Improvement Priority: High 🥇 Assign this label if this issue is VERY important or often used Difficulty: Medium 😐 This issue can be solved, but a decent amount of lines need to be changed labels Feb 22, 2024
@StephanAkkerman StephanAkkerman added the Overhaul 🌈 Overhaul a part of the code label May 26, 2024
@StephanAkkerman
Copy link
Owner Author

The coingecko wrapper does not support this, so we need to implement it ourselves

@StephanAkkerman
Copy link
Owner Author

Could use https://github.com/dotX12/aiocoingecko, but is 3 years old...

@StephanAkkerman StephanAkkerman mentioned this issue Aug 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Medium 😐 This issue can be solved, but a decent amount of lines need to be changed Improvement 📈 Improvement Overhaul 🌈 Overhaul a part of the code Priority: High 🥇 Assign this label if this issue is VERY important or often used
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StephanAkkerman