Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSO(Globular star cluster) info bug #3782

Closed
3domennotry opened this issue Jun 27, 2024 · 5 comments
Closed

DSO(Globular star cluster) info bug #3782

3domennotry opened this issue Jun 27, 2024 · 5 comments
Assignees
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Milestone

Comments

@3domennotry
Copy link

Expected Behaviour

Show "Morphological description" "intermediate rich concentrations of stars".

Actual Behaviour

Show "Morphological description" "high concentration of stars toward the center".

Steps to reproduce

Show Configuration window.
Select "All available" in "Selected object information".

Select one in sky. (example:M15)
20240627

System

  • Stellarium version: stellarium-24.2-qt5-win32.exe
  • Operating system: Win7 32bit

(Sorry, I can not speak English very well.)

I think so that this bug occures by 2 reason.

src/core/modules/Nebula.cpp
line 1374
static const QRegularExpression GlClRx("\.(I|II|III|IV|V|VI|VI|VII|VIII|IX|X|XI|XII)\.");
I think so that "VI" is a duplicate.

src/core/modules/Nebula.cpp
line 1374 to line 1424

If value is "II" or "III" or "IV" or "IX", make a mistake "I". go to "case 0:".
As same as, If value is "VI" or "VII" or "VIII", make a mistake "V".
As same as, If value is "XI" or "XII", make a mistake "X".
Because this code mistake judge only first char.

I do not understand that way of report in Github.
I create this report 3times.
I pray that This report is visible.

thank you.

@alex-w alex-w self-assigned this Jun 27, 2024
@alex-w alex-w added this to the 24.3 milestone Jun 27, 2024
@alex-w alex-w added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue labels Jun 27, 2024
Copy link

Hello @3domennotry!

OK, developers can reproduce the issue. Thanks for the report!

@3domennotry
Copy link
Author

Thank you very much.

@alex-w alex-w reopened this Jun 27, 2024
@alex-w alex-w closed this as completed in 433009c Jul 2, 2024
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Hello @3domennotry!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@3domennotry
Copy link
Author

I have confirmed that this bug has been fixed.
Thank you very much.

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Sep 22, 2024
Copy link

Hello @3domennotry!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Development

No branches or pull requests

2 participants