Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDNClient methods that accept string host download via http #677

Closed
xPaw opened this issue May 11, 2019 · 2 comments · Fixed by #678
Closed

CDNClient methods that accept string host download via http #677

xPaw opened this issue May 11, 2019 · 2 comments · Fixed by #678
Milestone

Comments

@xPaw
Copy link
Member

xPaw commented May 11, 2019

DownloadManifestAsync and DownloadDepotChunkAsync automatically turn the passed host string into a Server object with HTTP as the protocol. As a consumer I can't control this behaviour (the core method is private and I can't pass my own Server object in)

@yaakov-h
Copy link
Member

It seems that this is technically possible with:

ConnectAsync -> AuthenticateDepotAsync -> DownloadManifestAsync/DownloadDepotChunkAsync.

With a smarter consumer doing their own management, we should have a way to streamline this process.

@xPaw
Copy link
Member Author

xPaw commented May 11, 2019

I think the easy way of fixing it would be making DownloadDepotChunkCoreAsync a public overload of DownloadDepotChunkAsync

same with DownloadManifestAsync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants