New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping starlette for ASGI typing #2

Open

jerluc opened this issue Feb 23, 2022 · 1 comment

Assignees

Labels

Member

jerluc commented Feb 23, 2022

Currently, we rely on the starlette module solely for the purposes of:

Type annotations for mypy
Extracting a handful of HTTP-specific attributes from various ASGI dicts (scope, receive, send, message)

While this is certainly handy, we definitely don't need to depend on an entire server library just to do this work.

Are there any type/data-only packages that can do this without also including an entire server/framework?

The text was updated successfully, but these errors were encountered:

jerluc added the enhancement label

Member Author

jerluc commented May 25, 2023

Also relevant: both #3 and #4 (which were security-related patches) could likely be avoided by moving away from starlette.

jerluc self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment