Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added s3 proxy default page #136

Merged
merged 2 commits into from
May 15, 2023
Merged

added s3 proxy default page #136

merged 2 commits into from
May 15, 2023

Conversation

mathis-marcotte
Copy link

@mathis-marcotte mathis-marcotte commented May 5, 2023 •
edited
Loading

For StatCan/aaw#1641

Should be live on dev. To test, just hit the Storage menu item in kubeflow when on a namespace that is not opted-in to s3.

@mathis-marcotte mathis-marcotte added the auto-deploy Trigger manual CI steps for this CI label May 5, 2023
chuckbelisle
chuckbelisle approved these changes May 15, 2023
View reviewed changes
Copy link

@chuckbelisle chuckbelisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to correct the typo in the French message

components/centraldashboard/public/assets/i18n/languages.json Outdated Show resolved Hide resolved
@chuckbelisle chuckbelisle merged commit 48fb857 into stc-master May 15, 2023
@chuckbelisle chuckbelisle deleted the s3proxy-default-page branch May 15, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckbelisle chuckbelisle chuckbelisle approved these changes

Assignees
No one assigned
Labels
auto-deploy Trigger manual CI steps for this CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathis-marcotte @chuckbelisle