Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create default page for non-opted in s3proxy users #1641

Closed
Jose-Matsuda opened this issue Apr 14, 2023 · 3 comments
Closed

Create default page for non-opted in s3proxy users #1641

Jose-Matsuda opened this issue Apr 14, 2023 · 3 comments
Assignees

Comments

@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Apr 14, 2023

Related to: #1538 (comment)

Need default virtualservice for the "Storage" button on the kubeflow interface.

There needs to be a "404" page for users who have not opted in to s3proxy rather than a blanc "no route found" message from kubeflow.

Jose Questions

  1. Where will the 404 page be? Will we add a page to central dashboard and then the VS reroutes it to that on failure?
  2. I suppose we add user documentation for what the Storage button is for

Mathis Question

Do we even want to show the user the storage option if they're not in it?

Result

After discussing during technical elaboration, we will first hide the storage option from the menu items. In the future, we will implement a proper page to display when users haven't opted-in to s3proxy.

@mathis-marcotte mathis-marcotte self-assigned this Apr 19, 2023
@mathis-marcotte mathis-marcotte changed the title Create default VS for non-opted in s3proxy users Remove menu link for non-opted in s3proxy users May 3, 2023
@mathis-marcotte
Copy link
Contributor

After looking into it, just temporarily removing the link would probably be more work than just already implementing the default page. So the ticket will revert to its original goal.

@mathis-marcotte mathis-marcotte changed the title Remove menu link for non-opted in s3proxy users Create default page for non-opted in s3proxy users May 5, 2023
@mathis-marcotte
Copy link
Contributor

mathis-marcotte commented May 5, 2023

When looking into this, there didn't seem to be a need for a virtual service to accomplish this. In the central dashboard code, there was already logic in place to determine if an iframe failed to load. So, it was just a matter of appending on to that so that if it failed while trying to get s3 proxy, itwould just redirect to the newly created default s3 proxy page instead of the generic "no page found" error page.

While testing, I had two namespaces: "mathis-marcotte" which had s3proxy and "mathis-test" which did not have s3 proxy. When clicking on the "storage" link with my first namespace, we can see that it can access the s3proxy explorer through the iframe.
image

When trying to access it with my second namespace, we can see that it does not have access and the default page is displayed(the page is very basic for now with just a message that is a bit more detailed compared to the "page not found" message).
image

@mathis-marcotte
Copy link
Contributor

Merged with the solution mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants