Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyterlab markdown and raw cell error #77

Closed
saffaalvi opened this issue Jul 21, 2020 · 10 comments
Closed

jupyterlab markdown and raw cell error #77

saffaalvi opened this issue Jul 21, 2020 · 10 comments

Comments

@saffaalvi
Copy link
Contributor

saffaalvi commented Jul 21, 2020

When a new markdown or raw cell are added to a notebook, an error repeatedly pops up every time you try to interact with the cell:

errorconsole

I've tried this with 3 images: minimal-notebook-cpu, machine-learning-notebook-cpu, and geomatics-notebook-cpu and they all had the same problem. This only seems to be a problem with newly created notebook servers as it was tested with a notebook from ~2 weeks ago and a machine-leaning-notebook-cpu from 43 days ago and no errors came up.

The commit SHA for the working machine-learning-notebook-cpu is 562fa4a

@ca-scribner
Copy link
Contributor

To reproduce this, if you create a markdown cell you have to wait a moment for the error to show. If you create a markdown cell and immediately populate it, the error wont come up

@sylus
Copy link
Member

sylus commented Jul 22, 2020

kubeflow-kale/kale#165

@sylus
Copy link
Member

sylus commented Jul 22, 2020

I just merged a PR that temporarily reverts Kale, new containers should be rdy in an hour.

@saffaalvi
Copy link
Contributor Author

I made the change to use jlpm instead of npm in the minimal-notebook/cpu/Dockerfile and minimal-notebook/gpu/Dockerfile which can be seen in 746d058...e760c19 (can ignore FROM base change as local image was used to build the container).

The issue with the markdown and raw cells was still there even after these changes were made.

@saffaalvi
Copy link
Contributor Author

saffaalvi commented Jul 27, 2020

Looks like the LSP extension is actually throwing the error here which is triggering kale's handler to display the dialog with the error message.

An issue was previously created by @sylus on kubeflow-kale's Github page: kubeflow-kale/kale#165 and I have created an issue for this on the jupyterlab-lps Github page as well: https://github.com/krassowski/jupyterlab-lsp/issues/299

For now if we want to use the kale extension, a quick fix would be to just disable LSP when running kale.

@sylus
Copy link
Member

sylus commented Aug 6, 2020

This is now fixed upstream, can we test now?

@saffaalvi
Copy link
Contributor Author

When creating a new server with the custom image http://k8scc01covidacr.azurecr.io/minimal-notebook-cpu:6fa16e8f0d1534d2b39e0fece7f2147442fcd0db, when a new notebook with Python3 is created, the following error appears:

RPC

When a new notebook with Go, Julia, Python 3.7, and R is created, the above error appears as well as a new error:

error

@sylus
Copy link
Member

sylus commented Aug 7, 2020

Yeah confirmed probably should rename this issue since is slightly different now.

@sylus
Copy link
Member

sylus commented Aug 7, 2020

I think this should fix it:

#88

Pushed a test and seems to have fixed when deployed.

@sylus
Copy link
Member

sylus commented Aug 7, 2020

I'm going to close this out please open a new issue if problem persists am doing the building of containers right now

@sylus sylus closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants