Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log into Github #2

Open
Noggog opened this issue Aug 16, 2023 · 4 comments
Open

Log into Github #2

Noggog opened this issue Aug 16, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Noggog
Copy link
Member

Noggog commented Aug 16, 2023

Might be nice to add some tech where users are able to log into github on the SCP website, and associate their account. This would give the SCP access to basic things like email and account name. Would be used alongside #1, most likely

@Pickysaurus
Copy link
Member

I've intentionally used Nexus Mods only for the website login, with the thinking being if you have a GitHub account you can simply come direct to the repo instead.

@Noggog
Copy link
Member Author

Noggog commented Aug 21, 2023

Id say the main reasoning behind adding it potentially is to associating submissions via #1. If a user submits something via the website, then currently there's no way to associate that with a github account to add them as an author to the commit. It could be argued that if they have a github account, why are they using the site to submit? Fair, but there might be a user category that has made an account to participate in github issue discussions and might want to contribute, but still don't want to dip their toes into git cloning and Spriggit conversions?

Maybe not worth the effort.

Also, I'm currently unfamiliar with the mechanics of how the starfield site associates github issues with the initiating user when making new issues via the site. How is the "My Issues" page populated currently? If I were to make one issue via the site, and one issue via github, would they both show up in that list somehow?

@Pickysaurus
Copy link
Member

It's fairly crude because of the way GitHub doesn't let you assign extra metadata.

Comments and issues created via the website have the following appended.

<!-- NexusMods:123445 -->

Where the number is their user ID. Then when the website renders the comment or issue it uses this to get their account info.

@Noggog
Copy link
Member Author

Noggog commented Aug 22, 2023

Good to know!
I dont think we -have- to log into Github, but good to brainstorm about it in case we get inspired to upgrade and get fancy later.

Being able to better facilitate #1 is the main draw, but sounds like it would help a slight bit with identifying issues as well:

  • issues opened via the website get made with the logged in Github account, rather than needing the ID appended to the title.
  • on the "My Issues", it could look for NexusIDs in the title, but also grab and display any issues created by the logged in github user. So a union of both ways of identifying the user for a more reliably full list.

@Pickysaurus Pickysaurus added the enhancement New feature or request label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants