-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log into Github #2
Comments
I've intentionally used Nexus Mods only for the website login, with the thinking being if you have a GitHub account you can simply come direct to the repo instead. |
Id say the main reasoning behind adding it potentially is to associating submissions via #1. If a user submits something via the website, then currently there's no way to associate that with a github account to add them as an author to the commit. It could be argued that if they have a github account, why are they using the site to submit? Fair, but there might be a user category that has made an account to participate in github issue discussions and might want to contribute, but still don't want to dip their toes into git cloning and Spriggit conversions? Maybe not worth the effort. Also, I'm currently unfamiliar with the mechanics of how the starfield site associates github issues with the initiating user when making new issues via the site. How is the "My Issues" page populated currently? If I were to make one issue via the site, and one issue via github, would they both show up in that list somehow? |
It's fairly crude because of the way GitHub doesn't let you assign extra metadata. Comments and issues created via the website have the following appended.
Where the number is their user ID. Then when the website renders the comment or issue it uses this to get their account info. |
Good to know! Being able to better facilitate #1 is the main draw, but sounds like it would help a slight bit with identifying issues as well:
|
Might be nice to add some tech where users are able to log into github on the SCP website, and associate their account. This would give the SCP access to basic things like email and account name. Would be used alongside #1, most likely
The text was updated successfully, but these errors were encountered: