Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Suggestion?] OBJModel3D widget does not support line declaration #102

Closed
hohserg1 opened this issue Jan 16, 2021 · 5 comments
Closed

Comments

@hohserg1
Copy link
Contributor

hohserg1 commented Jan 16, 2021

Describe the bug
Line declaration in obj model does not produce render effect

In which environment did the Bug appear?
Singleplayer

To Reproduce
Steps to reproduce the behavior:

  1. Create file /home/test.obj with content:
v 0 0 0
v 1 0 0
v 1 0 1
v 1 1 1
v 1 1 0

l 1 2 3 4 5

f 1 2 3
  1. open lua repl
  2. Execute w=component.glasses.addOBJModel3D()
  3. Execute w.loadObj(io.open("/home/test.obj"):read("*a"))
  4. Execute w.addTranslation(x,y,z) to move widget to comfortable coords
  5. Execute w.addColor(1,0,0,1)
  6. See red triangle but no see line

Expected behavior
Line must render
https://en.wikipedia.org/wiki/Wavefront_.obj_file#Line_elements

Screenshots / Code Snippet
image

Minecraft:

  • Mod Version - OpenGlasses-MC1.12.2-2.2-53
  • Minecraft Version - 1.12.2
  • Forge Version - 14.23.5.2854
@hohserg1
Copy link
Contributor Author

Ok, I found here that's line declaration really unsupported
image
And this issue must be suggestion of addition line support of obj format

@hohserg1 hohserg1 changed the title [Bug] OBJModel3D widget does not support line declaration [Bug/Suggestion?] OBJModel3D widget does not support line declaration Jan 16, 2021
@hohserg1
Copy link
Contributor Author

@ben-mkiv is Commons0815 open-source? Can I contribute to it?

@ben-mkiv
Copy link
Collaborator

@ben-mkiv is Commons0815 open-source? Can I contribute to it?

now it is again, https://github.com/ben-mkiv/commons0815

if you want to add the feature go ahead, if you want it in the official build you can make an PR and i'll merge it

@hohserg1
Copy link
Contributor Author

Yeah, Thx!

@ben-mkiv
Copy link
Collaborator

Feature got merged and is in the latest commons0815 (1.4.0) release on curseForge
https://www.curseforge.com/minecraft/mc-mods/commons0815/files/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants