Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] (Part 2) Support Iceberg partition transform with multi partition columns #52966

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Nov 18, 2024

Why I'm doing:

What I'm doing:

Fixes #52576

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing requested review from a team as code owners November 18, 2024 03:33
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing changed the title [Feature] [WIP] Support Iceberg partition transform with multi partition columns [Feature] (Part 2) [WIP] Support Iceberg partition transform with multi partition columns Nov 18, 2024
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing changed the title [Feature] (Part 2) [WIP] Support Iceberg partition transform with multi partition columns [Feature] (Part 2) Support Iceberg partition transform with multi partition columns Nov 18, 2024
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.2% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 293 / 336 (87.20%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/rule/TextMatchBasedRewriteRule.java 6 10 60.00% [261, 262, 266, 267]
🔵 com/starrocks/scheduler/mv/MVPCTRefreshListPartitioner.java 34 41 82.93% [203, 204, 213, 225, 226, 264, 287]
🔵 com/starrocks/server/LocalMetastore.java 16 19 84.21% [3050, 3056, 3057]
🔵 com/starrocks/sql/analyzer/MaterializedViewAnalyzer.java 126 148 85.14% [956, 957, 1079, 1081, 1082, 1088, 1090, 1111, 1116, 1436, 1437, 1443, 1444, 1472, 1474, 1480, 1481, 1482, 1497, 1510, 1573, 1574]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java 6 7 85.71% [1442]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/compensation/MVCompensationBuilder.java 29 33 87.88% [247, 248, 249, 250]
🔵 com/starrocks/catalog/MaterializedView.java 36 38 94.74% [1846, 1847]
🔵 com/starrocks/connector/iceberg/IcebergPartitionUtils.java 21 21 100.00% []
🔵 com/starrocks/sql/ast/UnitIdentifier.java 1 1 100.00% []
🔵 com/starrocks/sql/ast/CreateMaterializedViewStatement.java 2 2 100.00% []
🔵 com/starrocks/catalog/MvBaseTableUpdateInfo.java 1 1 100.00% []
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rewrite/OptExternalPartitionPruner.java 1 1 100.00% []
🔵 com/starrocks/sql/common/PListCell.java 12 12 100.00% []
🔵 com/starrocks/sql/ast/IntervalLiteral.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multi partition exprs for mv
1 participant