Skip to content

Commit

Permalink
Improve Accessibility
Browse files Browse the repository at this point in the history
  • Loading branch information
PSchmiedmayer committed Sep 26, 2023
1 parent cfe5c72 commit c572211
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 3 deletions.
1 change: 1 addition & 0 deletions TemplateApplication/Home.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ struct Home: View {
},
label: {
Image(systemName: "person.crop.circle")
.accessibilityLabel("Profile View")
}
)
}
Expand Down
1 change: 1 addition & 0 deletions TemplateApplication/Instructions/Instructions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ struct Instructions: View {
ForEach(steps, id: \.offset) { step in
HStack {
Image(systemName: "\(step.offset + 1).circle.fill")
.accessibilityHidden(true)

Check warning on line 20 in TemplateApplication/Instructions/Instructions.swift

View check run for this annotation

Codecov / codecov/patch

TemplateApplication/Instructions/Instructions.swift#L20

Added line #L20 was not covered by tests
.foregroundColor(Color("ButtonColor_light"))
.font(.system(size: 45))
.frame(minHeight: 90)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,10 @@ struct AccountSetup: View {
Group {
if account.signedIn {
Image(systemName: "person.badge.shield.checkmark.fill")
.accessibilityLabel("You are signed in")

Check warning on line 80 in TemplateApplication/Onboarding/AccountSetup/AccountSetup.swift

View check run for this annotation

Codecov / codecov/patch

TemplateApplication/Onboarding/AccountSetup/AccountSetup.swift#L80

Added line #L80 was not covered by tests
} else {
Image(systemName: "person.fill.badge.plus")
.accessibilityLabel("You can sign up or sign in")

Check warning on line 83 in TemplateApplication/Onboarding/AccountSetup/AccountSetup.swift

View check run for this annotation

Codecov / codecov/patch

TemplateApplication/Onboarding/AccountSetup/AccountSetup.swift#L83

Added line #L83 was not covered by tests
}
}
.font(.system(size: 150))
Expand Down
1 change: 1 addition & 0 deletions TemplateApplication/Onboarding/HealthKitPermissions.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ struct HealthKitPermissions: View {
)
Spacer()
Image(systemName: "heart.text.square.fill")
.accessibilityHidden(true)

Check warning on line 31 in TemplateApplication/Onboarding/HealthKitPermissions.swift

View check run for this annotation

Codecov / codecov/patch

TemplateApplication/Onboarding/HealthKitPermissions.swift#L31

Added line #L31 was not covered by tests
.font(.system(size: 150))
.foregroundColor(.accentColor)
Text("HEALTHKIT_PERMISSIONS_DESCRIPTION")
Expand Down
6 changes: 3 additions & 3 deletions TemplateApplication/Onboarding/Welcome.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@ struct Welcome: View {
subtitle: "WELCOME_SUBTITLE",
areas: [
.init(
icon: Image(systemName: "folder.badge.plus"),
icon: Image(systemName: "folder.badge.plus"), // swiftlint:disable:this accessibility_label_for_image
title: "WELCOME_AREA1_TITLE",
description: "WELCOME_AREA1_DESCRIPTION"
),
.init(
icon: Image(systemName: "magnifyingglass"),
icon: Image(systemName: "magnifyingglass"), // swiftlint:disable:this accessibility_label_for_image
title: "WELCOME_AREA2_TITLE",
description: "WELCOME_AREA2_DESCRIPTION"
),
.init(
icon: Image(systemName: "square.and.arrow.up"),
icon: Image(systemName: "square.and.arrow.up"), // swiftlint:disable:this accessibility_label_for_image
title: "WELCOME_AREA3_TITLE",
description: "WELCOME_AREA3_DESCRIPTION"
)
Expand Down
1 change: 1 addition & 0 deletions TemplateApplication/Overview/InstructionsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ struct InstructionsView: View {
var body: some View {
VStack(alignment: .center) {
Image(systemName: "doc.text.magnifyingglass")
.accessibilityHidden(true)
.font(.system(size: 90))
.foregroundColor(.accentColor)
.padding(.vertical, 8)
Expand Down
1 change: 1 addition & 0 deletions TemplateApplication/Overview/LLMSummaryView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ struct LLMSummaryView: View {
var body: some View {
VStack(alignment: .center) {
Image(systemName: "magnifyingglass")
.accessibilityHidden(true)

Check warning on line 26 in TemplateApplication/Overview/LLMSummaryView.swift

View check run for this annotation

Codecov / codecov/patch

TemplateApplication/Overview/LLMSummaryView.swift#L26

Added line #L26 was not covered by tests
.font(.system(size: 90))
.foregroundColor(.accentColor)
.padding(.vertical, 8)
Expand Down

0 comments on commit c572211

Please sign in to comment.