Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ENGAGE-HF to @stanfordbdhg/spezi-web-design-system #78

Merged
merged 16 commits into from
Nov 5, 2024

Conversation

arkadiuszbachorski
Copy link
Collaborator

Migrate ENGAGE-HF to @stanfordbdhg/spezi-web-design-system

♻️ Current situation & Problem

ENGAGE-HF still sources design system. Migrate to use https://github.com/StanfordSpezi/spezi-web-design-system

⚙️ Release Notes

  • Migrate ENGAGE-HF to @stanfordbdhg/spezi-web-design-system

📚 Documentation

This is a draft, because @stanfordbdhg/spezi-web-design-system is not yet published to NPM.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/migrate-to-new-design-system branch from 569061e to 1f229d4 Compare November 4, 2024 08:49
@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/migrate-to-new-design-system branch from 0b0052f to dd63b13 Compare November 5, 2024 11:13
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.92%. Comparing base (d61edc0) to head (dd63b13).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
routes/~__root.tsx 0.00% 8 Missing ⚠️
tailwind.config.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #78       +/-   ##
==========================================
- Coverage   30.93%   0.92%   -30.01%     
==========================================
  Files         186      71      -115     
  Lines        6525    3601     -2924     
  Branches      333      80      -253     
==========================================
- Hits         2018      33     -1985     
+ Misses       4421    3501      -920     
+ Partials       86      67       -19     
Files with missing lines Coverage Δ
components/AsideEngageLayout/AsideEngageLayout.tsx 0.00% <ø> (ø)
modules/firebase/AuthProvider.ts 0.00% <ø> (ø)
modules/firebase/UserProvider.tsx 0.00% <ø> (ø)
modules/firebase/app.ts 0.00% <ø> (ø)
modules/firebase/localizedText.ts 100.00% <ø> (ø)
modules/firebase/role.ts 0.00% <ø> (ø)
modules/firebase/utils.ts 0.00% <ø> (ø)
modules/notifications/Notification.tsx 0.00% <ø> (ø)
...cations/NotificationsTable/MarkAllAsReadButton.tsx 0.00% <ø> (ø)
...ations/NotificationsTable/ShowUnreadOnlySwitch.tsx 0.00% <ø> (ø)
... and 36 more

... and 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d61edc0...dd63b13. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski marked this pull request as ready for review November 5, 2024 11:16
@arkadiuszbachorski arkadiuszbachorski merged commit b2de489 into main Nov 5, 2024
8 of 10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/migrate-to-new-design-system branch November 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant