Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add barrierefreiheitserklärung #79

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

maehr
Copy link
Member

@maehr maehr commented Mar 11, 2024

Pull request

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features
    • Updated the analytics tracking to be active only on the production site to improve data accuracy.
    • Enhanced the accessibility statement to include a comprehensive overview, commitment, scope, adherence to standards, principles, staff training updates, identification of non-accessible features, and feedback contact information.
  • Bug Fixes
    • Fixed improper HTML structure in the search layout by adding missing closing </li> tags.

Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 50eaa1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Mar 11, 2024

Warning

Rate Limit Exceeded

@maehr has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 19 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between ce8de23 and 50eaa1f.

Walkthrough

This update focuses on enhancing website accessibility and structure. It includes updating the analytics setup to differentiate between production and development environments, correcting HTML structure in search layouts, and significantly expanding the accessibility declaration to emphasize commitment and compliance with standards.

Changes

File Path Change Summary
_includes/head/analytics.html Updated analytics code for production-only deployment
_layouts/search.html Added missing </li> tags for proper HTML structure
pages/.../barrierefreiheitserklaerung.md Expanded content to emphasize accessibility commitment, standards, and contact info for feedback

Related issues

Poem

In the web's vast meadow, under the digital sky,
A little rabbit worked, with a twinkle in its eye.
"Let's make this place welcoming, for all to roam free,
With paths clear and open, as vast as the sea."
🌟 Through code and through words, it hopped with delight,
Ensuring the web's garden was blooming and bright.
"For every soul wandering in this digital space,
Let's offer a haven, a warm, welcoming place." 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@maehr maehr requested review from koilebeit and mtwente March 11, 2024 10:19
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ce8de23 and f41790a.
Files selected for processing (3)
  • _includes/head/analytics.html (1 hunks)
  • _layouts/search.html (2 hunks)
  • pages/barrierefreiheitserklaerung.md (1 hunks)
Additional comments: 2
_layouts/search.html (1)
  • 26-33: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [29-42]

The addition of closing </li> tags within <ul> elements is a good practice for maintaining proper HTML structure and enhancing accessibility. Well done on making these adjustments.

pages/barrierefreiheitserklaerung.md (1)
  • 7-66: The content additions to barrierefreiheitserklaerung.md significantly enhance the site's accessibility information, covering important topics such as commitment to accessibility, standards, principles, and feedback mechanisms. This is a commendable effort towards making the site more inclusive.

However, there are several typographical and grammatical issues highlighted by the static analysis tool, such as the use of English typographical quotes instead of German ones, and the incorrect use of 'ss' instead of 'ß' in certain contexts. While these are minor, addressing them would improve the readability and professionalism of the content. For example:

  • Replace English typographical quotes with German ones ( to for opening quotes and to for closing quotes).
  • Use 'ß' instead of 'ss' following the new German orthography rules in words like 'außerdem'.

_includes/head/analytics.html Outdated Show resolved Hide resolved
@maehr maehr merged commit 0eed54a into Stadt-Geschichte-Basel:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants