-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for all linux pack actions #4999
Comments
As already mentioned via Slack, I'll take care of it and start working on it now. Am still testing the actions to see which one exactly fail on Centos8 and will start to work on the MR soon. |
Summary of failing actions:
All other actions work fine. |
Copying and pasting this from Slack: For the Same story for the I’m a little confused why the For the service action, it’s a
Set the For If you need help standing up a test environment to begin with, I would dig through the Travis config and rerun the same commands in a VM. |
The contrib
linux
pack has a few broken actions (check_loadavg
,check_processes
,dig
: #4993,diag_loadavg
,netstat
: #4947, possibly more) at least on CentOS 8. It's really disheartening to spin up StackStorm and immediately run into broken actions.We should add tests for those actions to the pack.
The tests from the
core
pack can be used as a template for writing tests for thelinux
pack.I will try to add tests for the
dig
action in my PR #4993, to serve as a concrete example, but adding tests would be a useful way to introduce somebody to developing StackStorm that would have an immediate impact.The text was updated successfully, but these errors were encountered: