Add Variable Replacement Support in Tirith Policies #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refeed
reviewed
Aug 27, 2024
refeed
reviewed
Aug 28, 2024
refeed
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Hi Samriddhi, so I just had a discussion with @Akshat0694 and @arunim2405 . So here are a few things that we decided:
- we'll also include the
metaand thefinal_evaluatorpart of the policy to be parametrized. Reason:evaluatorsis already the hugest part of the policy, addingmeta, andfinal_evaluatorkey won't hurt the performance so much pydash.get()already supports syntax likefoo.bar[2], could you test this locally? or even better, you could create unittests for these functions
refeed
reviewed
Aug 29, 2024
samriddhi99
force-pushed
the
parameterize-policies
branch
from
b86e176 to
8e48f71
Compare
…ses where the path was not found, and change syntax of entering the variable names
refeed
force-pushed
the
parameterize-policies
branch
4 times, most recently
from
9898bb1 to
c7bc6dd
Compare
refeed
force-pushed
the
parameterize-policies
branch
from
c7bc6dd to
485740b
Compare
|
|
I'll squash the commits once it's been reviewed and marked as good to go |
refeed
reviewed
Sep 5, 2024
|
@refeed Can you add me as a reviewer? |
|
@refeed @samriddhi99 LGTM. |
|
Thanks for the review @AkashS0510! |
refeed
approved these changes
Sep 17, 2024
AkashS0510
approved these changes
Sep 25, 2024
tejasvi541
added a commit
to tejasvi541/tirith-local
that referenced
this pull request
Oct 4, 2024
Fix: corrected the file name __init__.py Signed-off-by: pravo23 <[email protected]> Enhance GitHub Actions Workflow with PR Triggers (StackGuardian#148) * Add PR triggers to github actions workflow * Update lint.yml Centralized version definition to simplify version management (StackGuardian#142) Co-authored-by: Rafid Aslam <[email protected]> Update build_test.yml (StackGuardian#149) * Update build_test.yml * Update lint.yml Update logger initialization to use module-specific loggers StackGuardian#140 Changed "logger = logging.getLogger()" line of code to "logger = logging.getLogger(__name__)" in all files Removed the TODO Comments - "# TODO: At least add __name__ as the name for the logger" in all files StackGuardian#140 Removed RESULTS text from error Resolved - Generalize the function get_path_value_from_dict Refactor get_path_value_from_dict Moved get_path_value_from_dict to common.py. Refactored Kubernetes and JSON handler files to import from common.py. Updated Common.py Fix linting (StackGuardian#167) Add a getting started guide in README.md (StackGuardian#139) * Add a getting started guide in README.md * Add description of getting started activity, and some minor fixes Add maintainers in README and CODEOWNERS file Add additional rules and guidelines to contributing.md Add examples for commit messages and guidelines for solving issues Update CONTRIBUTING.md with guidelines about solving issues Add separate heading about solving issues, and add examples for writing descriptions in commit changes setup the docs base (StackGuardian#177) * created the template for the official documentation * setting up the environment * cleaned up the documentation setup * adjusted the color scheme * setup the basic pages for the tirith documentation * updated the intro page Add dev container Add dev container Closes StackGuardian#175 Update Readme.MD Simplify type checking in sort_collections() Closes StackGuardian#185 Add Variable Replacement Support in Tirith Policies (StackGuardian#171) * Add support for parameterizing Tirith policies * Use pydash.get() and check for match only if the value is of type str * Add variable replacement for meta and eval_expression in a policy * Add unit tests for policy parameterization, change return type for cases where the path was not found, and change syntax of entering the variable names * Fix linting * tirith parametrization --------- Co-authored-by: Rafid Aslam <[email protected]> Removed RESULTS text from error Resolved - Generalize the function get_path_value_from_dict Refactor get_path_value_from_dict Moved get_path_value_from_dict to common.py. Refactored Kubernetes and JSON handler files to import from common.py. Updated Common.py Fix linting (StackGuardian#167) Add a getting started guide in README.md (StackGuardian#139) * Add a getting started guide in README.md * Add description of getting started activity, and some minor fixes Add maintainers in README and CODEOWNERS file Add additional rules and guidelines to contributing.md Add examples for commit messages and guidelines for solving issues Update CONTRIBUTING.md with guidelines about solving issues Add separate heading about solving issues, and add examples for writing descriptions in commit changes Merge branch 'main' of https://github.com/StackGuardian/tirith
refeed
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Requested Changes - Changed some variable names to snake case - Removed unused imports from cli.py - Added Some dev dependencies like autopep8 and pylint for effective searches will remove before final commit - Added a custom py file to filter pylint logs, will remove before final commit * removed filter script and logs, and changed names where's its needed * Add installation instruction to README.md Fix: corrected the file name __init__.py Signed-off-by: pravo23 <[email protected]> Enhance GitHub Actions Workflow with PR Triggers (#148) * Add PR triggers to github actions workflow * Update lint.yml Centralized version definition to simplify version management (#142) Co-authored-by: Rafid Aslam <[email protected]> Update build_test.yml (#149) * Update build_test.yml * Update lint.yml Update logger initialization to use module-specific loggers #140 Changed "logger = logging.getLogger()" line of code to "logger = logging.getLogger(__name__)" in all files Removed the TODO Comments - "# TODO: At least add __name__ as the name for the logger" in all files #140 Removed RESULTS text from error Resolved - Generalize the function get_path_value_from_dict Refactor get_path_value_from_dict Moved get_path_value_from_dict to common.py. Refactored Kubernetes and JSON handler files to import from common.py. Updated Common.py Fix linting (#167) Add a getting started guide in README.md (#139) * Add a getting started guide in README.md * Add description of getting started activity, and some minor fixes Add maintainers in README and CODEOWNERS file Add additional rules and guidelines to contributing.md Add examples for commit messages and guidelines for solving issues Update CONTRIBUTING.md with guidelines about solving issues Add separate heading about solving issues, and add examples for writing descriptions in commit changes setup the docs base (#177) * created the template for the official documentation * setting up the environment * cleaned up the documentation setup * adjusted the color scheme * setup the basic pages for the tirith documentation * updated the intro page Add dev container Add dev container Closes #175 Update Readme.MD Simplify type checking in sort_collections() Closes #185 Add Variable Replacement Support in Tirith Policies (#171) * Add support for parameterizing Tirith policies * Use pydash.get() and check for match only if the value is of type str * Add variable replacement for meta and eval_expression in a policy * Add unit tests for policy parameterization, change return type for cases where the path was not found, and change syntax of entering the variable names * Fix linting * tirith parametrization --------- Co-authored-by: Rafid Aslam <[email protected]> Removed RESULTS text from error Resolved - Generalize the function get_path_value_from_dict Refactor get_path_value_from_dict Moved get_path_value_from_dict to common.py. Refactored Kubernetes and JSON handler files to import from common.py. Updated Common.py Fix linting (#167) Add a getting started guide in README.md (#139) * Add a getting started guide in README.md * Add description of getting started activity, and some minor fixes Add maintainers in README and CODEOWNERS file Add additional rules and guidelines to contributing.md Add examples for commit messages and guidelines for solving issues Update CONTRIBUTING.md with guidelines about solving issues Add separate heading about solving issues, and add examples for writing descriptions in commit changes Merge branch 'main' of https://github.com/StackGuardian/tirith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #130
This PR introduces functionality to replace variables in Tirith policies with values from a provided dictionary. The replacement is currently applied only within the
evaluators. The newreplace_varsfunction uses regex to identify and substitute variables inprovider_argsandconditionfields.