ResourcePackStatusEvent is never called.

[avaruus1]

Affected Product(s)

SpongeVanilla

Version

1.16.5-8.1.0-RC1173

Operating System

Linux archlinux 5.19.1-zen1-1-zen

Java Version

18.0.2

Plugins/Mods

-

Describe the bug

ResourcePackStatusEvent never seems to be called. Listening to ServerboundResourcePackPacket manually works.

Link to logs

No response

[avaruus1]

After doing some digging, it seems like the only reason the server doesn't crash is because handleResourcePackResponse(...) in ServerGamePacketListenerImpl does not call PacketUtils.ensureRunningOnSameThread(...). Adding the call manually using mixin results in the server crashing with the following stacktrace: https://gist.github.com/avaruus1/3137ec794340040f7dd4fc477c6253ef

Notably present:
java.lang.AbstractMethodError: Receiver class net.minecraft.server.network.ServerGamePacketListenerImpl does not define or inherit an implementation of the resolved method 'abstract org.spongepowered.api.resourcepack.ResourcePack bridge$popReceivedResourcePack(boolean)' of interface org.spongepowered.common.bridge.server.network.ServerGamePacketListenerImplBridge.

While I have no idea whether just adding the call to ensureRunningOnSameThread & implementing the method(s) in the bridge would fix the issue, I hope that this information helps someone who knows something about Sponge internals to fix it 😃