Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LiteralTextMixin from core:invalid #2790

Closed
gabizou opened this issue Jun 28, 2020 · 0 comments · Fixed by #3074
Closed

Update LiteralTextMixin from core:invalid #2790

gabizou opened this issue Jun 28, 2020 · 0 comments · Fixed by #3074
Labels

Comments

@gabizou
Copy link
Member

gabizou commented Jun 28, 2020

Located in: core:invalid

Part of: text

This is part of the upgrade process for Sponge and is likely involving some work and investigation.

Advice and tips include:

  • Sometimes things are just a simple method name change
  • Might be a new class or field
  • Understanding what the original intention of the target code had
  • Analyzing whether the functionality achieved by the target class/mixin still exists
  • Understanding the new functionality in the new Minecraft version that requires rewriting for the functionality
  • The SpongeAPI usage could very well have gone missing out the window if functionality was deemed unnecessary for release
@kashike kashike linked a pull request Jul 20, 2020 that will close this issue
@kashike kashike closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants