Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectMapper issues when distributing Configurate 'Jar-in-Jar' #200

Closed
jpenilla opened this issue May 5, 2021 · 1 comment
Closed

ObjectMapper issues when distributing Configurate 'Jar-in-Jar' #200

jpenilla opened this issue May 5, 2021 · 1 comment

Comments

@jpenilla
Copy link
Contributor

jpenilla commented May 5, 2021

This issue occurs when using the ObjectMapper and jij'ing Configurate 4.1.0. When jij'ing 4.0.0, the issue is not present.

When using shadow to shade and relocate 4.1.0, the issue is also not present.

https://paste.gg/p/anonymous/15a7ffffebdc491eab0812614dd66d8d

This can be reproduced by building the latest commit of https://github.com/jpenilla/TabTPS and attempting to load the fabric version, which jij's Configurate 4.1.0.

@zml2008
Copy link
Member

zml2008 commented May 6, 2021

Resolved with f97a6ab for now, with longer-term plans discussed in #201 and #202.

Seems to be a restriction on setting final fields when using VarHandles -- I wonder if the restriction could be relaxed by passing a custom MethodHandles.Lookup to the field discoverer as well. Probably best to not depend on writing final fields though.

@zml2008 zml2008 closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants