TOTP: introduce new interface that prevents code reuse #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaubinix
force-pushed
the
totp-prevent-code-reuse
branch
from
c300614 to
2c8f53e
Compare
glaubinix
force-pushed
the
totp-prevent-code-reuse
branch
from
2c8f53e to
79aad1f
Compare
|
Hi, Many thanks for this PR. |
|
Thank you for the feedback! The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch: 11.4.x
Resolves issue #226
We did run into the same issue that was previously mentioned here where users can submit the same TOTP code multiple times.
To prevent this, a new interface was introduced with a new
verifyWithPreviousTimestampmethod that accepts an additional parameter, the timestamp of the last used code. Passing the parameter will prevent the code matching the timestamp, and in case leeway is used, the previous code, from being reused again. To make it possible to store the timestamp for the submitted code, the timestamp needs to be returned by theverifyWithPreviousTimestampmethod. Happy to adjust this to return a result object, in case that is preferred.