Added wrapper #21
Added wrapper #21
Conversation
public/src/utils/API.js
Outdated
| // baseURL: "https://spider.nitt.edu/bonafide/", | ||
| // baseURL: "http://localhost:3001/", | ||
| baseURL: "http://localhost:3001/", |
There was a problem hiding this comment.
We can remove this line. Dont include this in the PR
| .json(500) | ||
| .json({ message: "Some problem with the file upload" }); | ||
| // fs.unlinkSync(final_dest); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I understand the purpose of the function, but it feels too much hardcoded. If I want to add a column name, or add a new model, I have to change the code at a lot of places. You can optimize the function a bit, in two ways:
- See if it is possible to pass the model object itself as the argument, instead of modelName. Explore if there are any getter functions that can retreive all the attributes of the model. Since the row is a sequelize row, the model from which the row was extracted must be present in the row itself. So ideally, you need not even get the model object.
- Another way is to let the user specify what columns they want. Something like,
const row = await database.CertificateType.findAll({})
let {applier_roll, status} = my_wrapper(row, ['applier_roll', 'status'])
This array of arguments can also be received from the row model itself actually. Try exploring the attributes of row object and how you can exploit them.
routers/student.js
Outdated
| } | ||
| }); | ||
| return object; | ||
| } | ||
|
|
There was a problem hiding this comment.
You can define the function once in the helper.js file and import the function whever it is needed. No need to define it everywhere.
feat: 404 page
saisandhya01
force-pushed
the
wrapper_for_database_retrieval
branch
from
af8c0f6
to
0322e93
Compare
|
While rebasing, I got merge conflicts, that's why I guess there are more commits. The last commit is '0322e93'. |
|
Resolve all merge conflicts in your branch and then initiate the PR. |
|
I have already resolved the merge conflicts in the latest commit. |
Fix: Removed hardcoding of attributes in wrapper Removed repetition of code
saisandhya01
force-pushed
the
wrapper_for_database_retrieval
branch
from
0322e93
to
2b69d13
Compare
I have added the wrapper function. do check it. Also I have checked the working of the program, there were no errors