Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version for Nextcloud 23 missing #12

Closed
conrad784 opened this issue Mar 5, 2022 · 9 comments
Closed

Version for Nextcloud 23 missing #12

conrad784 opened this issue Mar 5, 2022 · 9 comments

Comments

@conrad784
Copy link
Contributor

After reading nextcloud/server#27846 it seems to be like only the valid versions have to be increased as there are no breaking changes.

It would be nice if #10 could be resolved in the same update.

@blackd
Copy link

blackd commented May 30, 2022

Just changing the manifest fixes it. Also works for 24

@CaptainBalou
Copy link

Just changing the manifest fixes it. Also works for 24

Could you explain how to do that?

@p-bo
Copy link

p-bo commented Dec 1, 2022

Just in case it wasn't noticed - Nextcloud improved policy regarding changes in core to ease app developers in maintaining compatibility with newer Nextcloud versions:

https://help.nextcloud.com/t/new-process-for-documenting-core-code-changes-that-affect-app-developers/149828?u=p-bo

@CaptainBalou
Copy link

@p-bo But this would nevertheless need that the maintainer of the project to get involved but I think he's very busy with other projects/tasks. 😳

@blackd
Copy link

blackd commented Dec 3, 2022

TBH between 22 and 24 the only change is in the manifest... and making new release. So not that time consuming.

If I had any idea of PHP I would have forked this already...

@CaptainBalou
Copy link

@blackd Same here. Thanks to your previous comment I searched for the manifest and changed it to be able to use it in 24. But there may come up a release which that won't work anymore. And also having this plugin offered in the plungin store is super convenient. So I would love to see these changes been commited. But as always this is all depending on priorities and I can understand that there sometimes are times were other things have to get higher priority. But maybe it would be possible to let other contributors get some permission to be allowed to commit their own changes here. I don't know. Whatever would be there the decision has to be taken by the owner.

@blackd
Copy link

blackd commented Jan 28, 2023

works with 25.x
if someone is interested

@CaptainBalou
Copy link

I use it with 25.0.3. Works pretty good. No malfunction.

@qroac
Copy link
Contributor

qroac commented Sep 16, 2023

Sorry for not working on this for a long time.
I just released a new verison with changes for NC 27 made by contributors that raised the version requirement to NC 27

@qroac qroac closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants