From dc693a2f7ae8035d40d92a35fc872bb6c43b62d6 Mon Sep 17 00:00:00 2001 From: sksadjad Date: Wed, 22 Jun 2022 11:46:17 +0200 Subject: [PATCH] refactor: changed the clientCredential parameter from credentialManifest to credentialManifestUrl --- packages/ms-authenticator/__tests__/authenticators.test.ts | 2 +- packages/ms-authenticator/src/types/IMsAuthenticator.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/ms-authenticator/__tests__/authenticators.test.ts b/packages/ms-authenticator/__tests__/authenticators.test.ts index 06ccba641..bc1ebc369 100644 --- a/packages/ms-authenticator/__tests__/authenticators.test.ts +++ b/packages/ms-authenticator/__tests__/authenticators.test.ts @@ -8,7 +8,7 @@ describe('@sphereon/ms-authenticator', () => { azClientId: '04c2bd60-cdbf-4935-80dd-110fdf473e6e', azClientSecret:'', azTenantId: 'e2a42b2f-7460-4499-afc2-425315ef058a', - credentialManifest:'https://beta.eu.did.msidentity.com/v1.0/e2a42b2f-7460-4499-afc2-425315ef058a/verifiableCredential/contracts/VerifiedCredentialExpert2' + credentialManifestUrl:'https://beta.eu.did.msidentity.com/v1.0/e2a42b2f-7460-4499-afc2-425315ef058a/verifiableCredential/contracts/VerifiedCredentialExpert2' })).resolves.not.toBeNull(); }); diff --git a/packages/ms-authenticator/src/types/IMsAuthenticator.ts b/packages/ms-authenticator/src/types/IMsAuthenticator.ts index 2e82eac2f..b6bd3eb7a 100644 --- a/packages/ms-authenticator/src/types/IMsAuthenticator.ts +++ b/packages/ms-authenticator/src/types/IMsAuthenticator.ts @@ -4,7 +4,7 @@ import { IAgentContext } from '@veramo/core' * azClientId: clientId of the application you're trying to login * azClientSecret: secret of the application you're trying to login * azTenantId: your MS Azure tenantId - * credentialManifest: address of your credential manifest. usually in following format: + * credentialManifestUrl: url of your credential manifest. usually in following format: * https://beta.eu.did.msidentity.com/v1.0//verifiableCredential/contracts/ * authority: optional. if not provided, we'll use the azClientId to create the Tenanted format if provided should be one of these two formats: * - Tenanted: https://login.microsoftonline.com/{tenant}/, where {tenant} is either the GUID representing the tenant ID or a domain name associated with the tenant. @@ -16,7 +16,7 @@ export interface IMsAuthenticationClientCredentialArgs { azClientId: string azTenantId: string azClientSecret: string - credentialManifest: string + credentialManifestUrl: string authority?: string scopes?: string[] skipCache?: boolean