You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a protocol plugin calls purple_conv_chat_write with who="" (leading into conv_write_im) while the user hasn't entered corresponding conference room, then this code path:
LOG4CXX_WARN(logger, "handleConvMessagePayload: No conversation with name " << payload.buddyname());
will not be entered because nickname is empty, and the message will end up being displayed as private, as will all subsequent messages in this group chat even with who non-empty.
However, calling purple_conv_chat_write with who="" and PURPLE_MESSAGE_SYSTEM seems to be common practice, so perhaps there needs to be a way to handle such messages without accidentally handling them as private?
The text was updated successfully, but these errors were encountered:
If a protocol plugin calls
purple_conv_chat_write
withwho=""
(leading into conv_write_im) while the user hasn't entered corresponding conference room, then this code path:spectrum2/libtransport/NetworkPluginServer.cpp
Line 685 in 8ed55ba
will not be entered because nickname is empty, and the message will end up being displayed as private, as will all subsequent messages in this group chat even with
who
non-empty.However, calling
purple_conv_chat_write
withwho=""
and PURPLE_MESSAGE_SYSTEM seems to be common practice, so perhaps there needs to be a way to handle such messages without accidentally handling them as private?The text was updated successfully, but these errors were encountered: