Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When group chat messages are displayed as private #393

Open
ars3niy opened this issue Aug 27, 2020 · 0 comments
Open

When group chat messages are displayed as private #393

ars3niy opened this issue Aug 27, 2020 · 0 comments

Comments

@ars3niy
Copy link

ars3niy commented Aug 27, 2020

If a protocol plugin calls purple_conv_chat_write with who="" (leading into conv_write_im) while the user hasn't entered corresponding conference room, then this code path:

LOG4CXX_WARN(logger, "handleConvMessagePayload: No conversation with name " << payload.buddyname());

will not be entered because nickname is empty, and the message will end up being displayed as private, as will all subsequent messages in this group chat even with who non-empty.

However, calling purple_conv_chat_write with who="" and PURPLE_MESSAGE_SYSTEM seems to be common practice, so perhaps there needs to be a way to handle such messages without accidentally handling them as private?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant