Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issues when getting taxon_names #44

Open
rafelafrance opened this issue May 18, 2021 · 1 comment
Open

Minor issues when getting taxon_names #44

rafelafrance opened this issue May 18, 2021 · 1 comment

Comments

@rafelafrance
Copy link

rafelafrance commented May 18, 2021

This has been a really smooth API to work with.

Two very minor issues:

  1. When I query for species I get subspecies too. This may be a feature but it bit me when looking through the records.
  2. There are duplicate names in the DB. For example: "Eusynthemis guttata" is both under IDs 715483 and 709907.

https://sfg.taxonworks.org/api/v1/taxon_names?project_token=iu4ty6tOdWg_-cceoQjhyQ&taxon_name_id=707405&descendants=true&nomenclature_group=Species&per=10000

@mjy
Copy link
Member

mjy commented May 18, 2021

This has been a really smooth API to work with.

Wonderful to hear. Don't worry, we'll break it.

  1. When I query for species I get subspecies too. This may be a feature but it bit me when looking through the records.

Will resolve via SpeciesFileGroup/taxonworks#2263.

  1. There are duplicate names in the DB. For example: "Eusynthemis guttata" is both under IDs 715483 and 709907.

@debpaul @jcabbott13 welcome to the feedback loop. Time to start thinking how to effectively record and treat these issues. @jcabbott13 one thing we have done is have users like @rafelafrance who are savy with GH fill out issue in a project specific to a TW project, i.e. setup your own project.

We could image something slightly more sophisticated though this will require consumers to be wiling to write apps to write to a TW "log". For example something like a POST to /taxon_names/123/annotate?duplicate=true&user_token=123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants