Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain Bukkit Implementation? #95

Open
Sparky983 opened this issue Jul 3, 2023 · 1 comment
Open

Plain Bukkit Implementation? #95

Sparky983 opened this issue Jul 3, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed proposal To propose changes that may not be implemented

Comments

@Sparky983
Copy link
Owner

No description provided.

@Sparky983 Sparky983 added enhancement New feature or request proposal To propose changes that may not be implemented labels Jul 3, 2023
@Sparky983 Sparky983 added this to the Post 1.0 milestone Jul 3, 2023
@Sparky983 Sparky983 removed this from the Post 1.0 milestone Jul 16, 2023
@Sparky983
Copy link
Owner Author

Sparky983 commented Mar 25, 2024

#205

How do we handle Adventure?

Supporting Bukkit can be easy, but depending on to what degree of support is decided to be implemented, it can get complex quickly.

My main concerns are:

  • What should we display Components as on Bukkit?
    • Do we simply convert it to a legacy strings even though we lose lots of information?
    • Do we use access unstable APIs (e.g. CraftBukkit and/or NMS) and modify the item's NBT directly?
  • What should we display on Paper?
    • Should we still convert Components to legacy strings even though Paper supports Adventure and can display all information?
    • How will this affect shading? see platform-bukkit for adventure-platform

@Sparky983 Sparky983 added the help wanted Extra attention is needed label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed proposal To propose changes that may not be implemented
Projects
None yet
Development

No branches or pull requests

1 participant