azure-keyvault-controller: restrict Kubernetes event generation to changes #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a Kubernetes event is generated for each object at every sync loop in the controller. Events are generated even when there is no difference between the secret in Azure Key Vault and content of the secret/configMap. This means that with a high number of secrets, a storm of events are sent to the cluster at every sync loop.
This PR reshuffles the event generation a little, so events are only generated if there is an update to the secret because of a change in the Key Vault secret, or if a secret/configMap object is created or modified.
The reasoning is that there is no need for such a high number of events to be sent, and that Kubernetes events should denote a state change in the system.