Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom resync periods #371

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

wimi
Copy link
Contributor

@wimi wimi commented Jun 15, 2022

This PR solves issue #327

PR provides a global way of reconfiguring resync periods for k8s and Azure Key Vault informers from standard 30s.

@wimi wimi requested review from torresdal and 181192 as code owners June 15, 2022 14:14
@PsychoNineSix
Copy link

@torresdal @181192 Is it possible to get this merged?
If time is an issue maybe the project needs more maintainers?

@YvesZelros
Copy link

@181192 @toreandreb It's possible to review this pr ?

Copy link
Collaborator

@181192 181192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wimi , I'm sorry I haven't followed this one up.

@181192 181192 merged commit 15dee5b into SparebankenVest:master Aug 17, 2022
@wimi wimi deleted the custom_resync_periods branch August 18, 2022 13:10
@dimuskin
Copy link

dimuskin commented Sep 1, 2022

please update documentation (https://github.com/SparebankenVest/public-helm-charts/tree/master/stable/akv2k8s).
currently there are two parameters:

azureKeyVaultResyncPeriod
kubeResyncPeriod

with same description (Resync periods for the controller in seconds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants