Export pfx from secret as tls #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, we believe this PR will also solve this issue: #70 |
|
@181192 Already verified that these changes work in a real world scenario. Seems we have the same setup as described in #70. The certificate is used by our nginx controller. Important step here was that it is also using the I can check against the beta version that you provided if you want but as the code is the same I'm expecting the same successful result. |
|
Allright thanks @svjo! Correct, working with Ingress Nginx Controller tls secrets needs to have the server certificate first for Nginx to pick it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR helps using certificates stored as Base64 PFX inside a Azure Key Vault secret. These secrets are generate for example by Azure's App Service Certificate service. As this certificate isn't stored as Azure Key Vault Certificate it currently cannot be synced with akv2k8s to a Kubernetes secret.