Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonexistent secret update #167

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Fix nonexistent secret update #167

merged 1 commit into from
Mar 23, 2021

Conversation

yix
Copy link
Contributor

@yix yix commented Mar 22, 2021

Fixes #163 (updated)

@yix yix requested review from 181192 and torresdal as code owners March 22, 2021 17:17
Copy link
Collaborator

@181192 181192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor comment. Will test after 😄

@181192
Copy link
Collaborator

181192 commented Mar 23, 2021

Beautiful, working as expected, thanks! 🎉

@181192 181192 merged commit 94ba7a0 into SparebankenVest:master Mar 23, 2021
@181192
Copy link
Collaborator

181192 commented Mar 23, 2021

@yix Released controller 1.2.2 included in Helm chart 2.0.8 😊

@181192 181192 modified the milestone: Version 1.3.0 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Secret gets never populated if KeyVault entry was created after the secret template
2 participants