-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate crd with controller gen #159
Conversation
a71ee34
to
d25df20
Compare
Add controller-gen to tools.go Add crdgen target to Makefile Generate CRD for all api versions
Controller will update this later, not client/user
This reverts commit 7b1432c.
Update project files directly and no longer require project repo to be at GOPATH
Add v2alpha1 Add missing deepcopy for AzureIdentity
Group name updated from spv.no to keyvault.azure.spv.no
70794e9
to
1b76567
Compare
Missed generating clients due to having repo in non default GOPATH, updated |
Introduced breaking changes with generated crd that change group and crd name, that breaks all existing azurekeyvaultsecrets.spv.no applied to a cluster
Changes group identifier of generated code from Spv to AzureKeyVault
Mark status field as a subresource
Introduced breaking changes with generated crd that change group and crd name, that breaks all existing Added |
d3b4976
to
c3ee0bf
Compare
About this PR
This PR enables the generation of the CRDs from the APIs, using the controller-gen cli, which is part of the KubeBuilder project.
Annotations has been added to the types to make it as close as possible as the manually created CRD.
See the diff on the generated CRD here.
Changes
Some changes was needed to be done:
Poll
fromAzureKeyVaultObject
type 2db1085hack/update-codegen.sh
with running code-generator inside a container and modifying repository files directlyPrevious status field was only type object with preserve unknown fields enabled
Now it generates with correct fields
The spec field is also now required, but not status as the controller will update the status field later
Development Workflow
To generate client code
To generate crd