Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebCord Windows Installer immediately crashes, after showing the background.gif for half a second, cannot install. #437

Closed
2 of 7 tasks
GarnetSunset opened this issue Jul 5, 2023 · 10 comments
Assignees
Labels
status:duplicate This issue or pull request already exists status:patch-released Patched in current stable release type:bug Something isn't working

Comments

@GarnetSunset
Copy link

Aknowledgements

  • I have checked that there is no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • This bug affects Discord website.

  • This issue is confirmed to be reproduceable when WebCord is packaged
    on at least all three latest supported Electron major releases.

  • This issue is reproduceable in Chrome, Chromium or any
    Chromium-based browser, e.g Brave or Edge (please write in
    Additional Context which browser you have used if it is neither
    Chrome nor unmodified Chromium).

  • There are no fixes done to master which resolves this issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🪟️ Windows

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

Unsure, it's the installer.

Application version

Unsure, it's the installer.

Bug description

When going to install the app, the installer crashes before it can even open. Any ideas?

Video attached, I'm not sure where logs might be.

Additional context

Desktop.2023.07.04.-.23.50.36.02.mp4
@dominic-espo

This comment was marked as spam.

@ghost

This comment was marked as spam.

@arijitroy454
Copy link

arijitroy454 commented Jul 10, 2023

Same issue on windows 10 22h2, although i can see the installer for a brief second. doesnt install or create any shortcuts, puts some file on appdata, but launching it from there doesnt work, it doesnt open. looking at task manager shows it opens and immediately crashes. Happens with both 32 and 64 bit installers.

@cameronj86
Copy link

cameronj86 commented Jul 18, 2023

Was definitely about to complain about Windows 11 blocking .exe files until I saw this thread lol. Had already made registry edits and tried 1-2 other things unfortunately.

Since then, I downloaded the prior release which is working (save for no start menu icon for some reason.)

@SpacingBat3
Copy link
Owner

I'm pretty sure that's cause of #436 and could be marked as duplicate of it (Squirrel installer actually runs WebCord in background normally, as it expects for applications to provide hooks).

I'm personally not a fan of Squirrel tbh, I preffer popular NSIS (NullSoft) installers and installing WebCord to system directory (as it prevents messing around with app.asar by third-party software, unless it runs with administrative privileges). Possibly I will use a third-party maker or work myself on it as part of ReForged, then most likely I would drop Squirrel.

@SpacingBat3 SpacingBat3 added type:bug Something isn't working status:duplicate This issue or pull request already exists labels Jul 18, 2023
@GarnetSunset
Copy link
Author

Awesome, thanks man, yep, 4.1.0 works for me, but even after manually moving in the files for 4.3.0 into the dir where 4.1.0 gets installed the app won't launch again after that. :)

@z0mk
Copy link

z0mk commented Aug 6, 2023

I got mine to show the gif for 1 whole second, I win!

@SpacingBat3 SpacingBat3 added the status:patch-released Patched in current stable release label Aug 15, 2023
@SkullHex2
Copy link

Still having this issue on both 4.4.2 and 4.4.3

@SpacingBat3
Copy link
Owner

I saw WebCord to install in %AppData% with the installer and that installation entry was made to the registry, but no shortcuts were made to desktop or start menu with Squirrel once I've been testing it. I think this might be the expected behavior, or at least I'm not sure whenever Squirrel installer should create such files, but given there are hooks that applications are supposed to implement within their code, I wouldn't be suprised that Squirrel just doesn't do all steps here.
Either way, I'm strongly against implementing installer within the client – if it would be a seperate config or script that runs within Squirrel, I would implement it this way, but I don't want to add like a large OS-specific chunk of code for Windows just because installer isn't doing all job it (probably) should do.

@SkullHex2
Copy link

SkullHex2 commented Oct 9, 2023

Oh ok. So you're saying that the installation is working, and we simply have to add whatever shortcut we want.
Unfortunately I still get this error: #417
Deleting %APPDATA%\Roaming\WebCord\windowState, as suggested here, seems to fix it (at least temporarily).
Thank you for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:duplicate This issue or pull request already exists status:patch-released Patched in current stable release type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants