Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pasting images from outside of Webcord occasionally crashes WebCord #169

Closed
1 of 5 tasks
ghost opened this issue Jul 6, 2022 · 3 comments
Closed
1 of 5 tasks

Pasting images from outside of Webcord occasionally crashes WebCord #169

ghost opened this issue Jul 6, 2022 · 3 comments
Labels
status:patch-released Patched in current stable release type:bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 6, 2022

Aknowledgements

  • I have checked that there's no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • I can confirm that this is not an issue with the Discord website,
    but it is a problem specific to the WebCord itself. I have tested
    if this bug occurs on Chromium/Chrome or any other Chromium-based
    browser that uses unpatched/upstream Chromium engine.

  • I have tried running the build from the master branch and it does
    not have any fixes implemented according to my issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v19.0.6

Application version

v3.3.0

Bug description

Pasting an image from outside of the application (i.e. a browser window or a screenshot tool) sometimes freezes WebCord to the point where restarting it is necessary.

Additional context

I'm using the Flatpak version of this application under Gnome (Wayland).
I have blocked the /typing endpoint, and all third-party websites except for the "GIF Providers" in the WebCord settings.
The only permission granted to Discord is Desktop capture.
I have also disabled hiding the window to the system tray, as Gnome doesn't come with a system tray.
I have encountered the same issue, under Gnome, with a different GPU (NVidia as opposed to an Intel TigerLake) and different CPU manufacturer (AMD as apposed to an Intel chip).

@ghost ghost added the type:bug Something isn't working label Jul 6, 2022
@ghost ghost assigned SpacingBat3 Jul 6, 2022
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Jul 6, 2022

This might be due to the new mechanism I have implemented to actually make pasting images from the web functional. I guess it might be stuck at infinite loop where it does re-emit the event, but still finds it of wrong type.

And it is actually hard to trully fix the paste bug for me, I've just noticed some differences that occur for me to know whenever it has been fixed or not.

I guess I need to go back to remove HTML from clipboard, re-emit event, add HTML back method. Or find how HTML content changes in the clipboard to know why this bug occurs.

@ghost
Copy link
Author

ghost commented Jul 6, 2022

This might be due to the new mechanism I have implemented to actually make pasting images from the web functional. I guess it might be stuck at infinite loop where it does re-emit the event, but still finds it of wrong type.

And it is actually hard to trully fix the paste bug for me, I've just noticed some differences that occur for me to know whenever it has been fixed or not.

I guess I need to go back to remove HTML from clipboard, re-emit event, add HTML back method. Or find how HTML content changes in the clipboard to know why this bug occurs.

Alright, I see. I'm not entirely sure there's any HTML content in my clipboard.

It seems the issue has a higher probability of occurring if it's with a large image.

@SpacingBat3
Copy link
Owner

It should not freeze since commit b70c764, as WebCord will detect and prevent loops so event won't be re-emitted infinitely. However if it still does, I doubt I can do anything about it.

@SpacingBat3 SpacingBat3 added the status:patch-released Patched in current stable release label Jul 18, 2022
@SpacingBat3 SpacingBat3 removed their assignment Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:patch-released Patched in current stable release type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant