-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prs/adding pickle output to cli #64
Conversation
You can use the cli like so: rookify --show the later will parse for the device section. If a section does not exist an error is thrown. |
In general I like the option to filter outputs. What needs to be changed is that each module should present it's understanding of the state data on it's own instead of an "one fits all" approach to just output everything as a JSON blob. |
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
bbac0c4
to
821a914
Compare
Signed-off-by: Boekhorst <[email protected]>
821a914
to
6fe4b39
Compare
Signed-off-by: Boekhorst <[email protected]>
…rogress Signed-off-by: Boekhorst <[email protected]>
…ith progressper module Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
…code Signed-off-by: Boekhorst <[email protected]>
Signed-off-by: Boekhorst <[email protected]>
…own status-mode? Signed-off-by: Boekhorst <[email protected]>
Ok cli has some more features, most of all the show-progress feature:
I only implemented it for Running of
And I was thinking, that it would be nice to have extra arguments to run the command for each module to check the status.' Also added a lot of tests |
This partly revers commit 3e9d54d. This reverts commit e15ce26. This reverts commit bff688c. Signed-off-by: Tobias Wolf <[email protected]>
This reverts commit b33cd08. Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@boekhorstb1: Please check if you want to add or change anything on your adapted changes :) Feel free to go ahead merging otherwise
This reverts commit a30c9ca. Signed-off-by: Tobias Wolf <[email protected]>
b523b6d
to
e1261bb
Compare
Signed-off-by: Tobias Wolf <[email protected]>
e1261bb
to
6604ec2
Compare
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
Signed-off-by: Tobias Wolf <[email protected]>
1bbb570
to
94a029c
Compare
This implements a generic fix to use `repr()` for data to be encoded to JSON values that would normally cause errors like: `TypeError: Object of type datetime is not JSON serializable` Signed-off-by: Tobias Wolf <[email protected]>
see issue: #60