Fix issues obtaining the JWT #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rixth I'll try this out sometime tomorrow! |
|
From a quick test - it seems to run, thanks! Can you change all of the instances of 200 in the tests to 302? Otherwise it wont output a release |
|
@rixth, let me know if you can't get around to finishing the PR, I can try and jump in. |
Couple things have broken/changed: * `LoginComplete` now 500s on a `null` being sent as the `ReturnUrl`. Send a valid value. * `LoginComplete` now returns a 302 on success. Cookies are only returned by `aiohttp` for the last request that was followed, so we need to disable following redirects. I confirmed that error handling for invalid username/password still works as expected. Resolves Southern-Company-HA/southern-company-hacs#80
|
@Lash-L good to go! |
|
Thank you @rixth |
|
@rixth If you have time, please investigate it still not working properly on the hacs integration. I have not done much with it, but I did bump the version and do some other 'chores' on the repo |
|
Please ignore - I should have it fixed in the latest update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple things have broken/changed on SC's end.
LoginCompletenow 500s on anullbeing sent as theReturnUrl. Send a valid value.LoginCompletenow returns a 302 on success. Cookies are only returned byaiohttpfor the last request that was followed, so we need to disable following redirects.I confirmed that error handling for invalid username/password still works as expected.
Resolves Southern-Company-HA/southern-company-hacs#80
cc @Lash-L @dcsim0n