Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore .jl files in .gitignore #26

Closed
mdavezac opened this issue Aug 28, 2022 · 0 comments
Closed

Do not ignore .jl files in .gitignore #26

mdavezac opened this issue Aug 28, 2022 · 0 comments

Comments

@mdavezac
Copy link

mdavezac commented Aug 28, 2022

The entry */.jl in .gitignore files makes it more difficult to navigate the code since many tools (for instance ripgrep, docker, etc...) will ignore these files. I would recommend removing the */.jl entry so the code can easily be searched with standard tools.

Github recommends this file (though for research reproducibility purposes, the last line excluding Manifest.toml is probably a bad idea).

There's also an opt-in approach that might more closely reproduce the current setup.

This is not a requirement for openjournals/joss-reviews#4694. Please do close the issue if you disagree with the recommendation ;).

@SotaYoshida SotaYoshida mentioned this issue Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants