Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the sortablejs dependency #84

Closed
p-himik opened this issue Oct 8, 2019 · 2 comments
Closed

Update the sortablejs dependency #84

p-himik opened this issue Oct 8, 2019 · 2 comments

Comments

@p-himik
Copy link

p-himik commented Oct 8, 2019

The README instructs users to install [email protected]. It's quite outdated and doesn't have many of the useful features the latest version has.

I tried installing 1.10.1 and it seems to work just fine, except for the animations. It seems that animations stopped working in 1.8.0-rc1. It would be great to have them working as well, however I have no idea how to fix them.
@p-himik
Copy link
Author

p-himik commented Oct 9, 2019

Turns out, the animations issue is because Google Closure compiler removes the code that triggers the repaint. It has nothing to do with React itself. More details.

But with that being said, I think it would still make sense to update the version of sortablejs used in this library.

@waynevanson
Copy link
Collaborator

waynevanson commented Oct 19, 2019 •
edited
Loading

@p-himik You should check out the new typescript rewrite here. Install with yarn add react-sortablejs-typescript because it uses the latest v1.10.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p-himik @waynevanson