Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KatipContextT Example with MonadLogger Support #78

Open
jkachmar opened this issue Dec 6, 2017 · 1 comment
Open

KatipContextT Example with MonadLogger Support #78

jkachmar opened this issue Dec 6, 2017 · 1 comment

Comments

@jkachmar
Copy link

jkachmar commented Dec 6, 2017

I've run into a few situations where having a MonadLogger orphan instance for KatipContextT has been helpful to interface with libraries that only export that interface for logging (so far, it's mainly been useful when interfacing with Persistent).

I've seen a few comments before about this in issues, or in other repos, but it usually takes a little work to find an example to go off of if you're not sure where to look.

If I extracted something small for a PR to the examples directory, would that be welcome here?

@MichaelXavier
Copy link
Collaborator

You may want to take a look at #27

Someone there did some work on a separate package that provides this and I think I'd prefer this be in a second package (which I'll happily promote in the readme or wherever else makes sense when it's released) to avoid bringing in dependencies that aren't frequently required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants