Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S110: Update the rule behavior to not count classes defined into another root namespace #601

Closed
Evangelink opened this issue Jul 26, 2017 · 0 comments
Assignees
Milestone

Comments

@Evangelink
Copy link
Contributor

Evangelink commented Jul 26, 2017

The idea here is to rewrite the rule to automatically exclude types that are not defined in the same root namespace. We will keep the filteredClasses parameter to let users define some specific classes/namespace to ignore.

Examples:

  • SonarSource.Product1.MyClass inherits from SonarSource.Product1.BaseClass then we count (both are defined in SonarSource root namespace.
  • SonarSource.Product1.MyClass inherits from SonarSource.Common.BaseClass then we count (both are defined in SonarSource root namespace (even if product is different).
  • SonarSource.Product1.MyClass inherits from System.Exception then we DON'T count (not defined in same root namespace).

RSPEC-110 needs to be updated for C#.

@Evangelink Evangelink added this to the 6.4 milestone Jul 28, 2017
@michalb-sonar michalb-sonar changed the title Rewrite S110: Update the rule behavior to not count classes defined into another root namespace Update S110: Update the rule behavior to not count classes defined into another root namespace Aug 1, 2017
@michalb-sonar michalb-sonar self-assigned this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants