Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3242: Rule should not trigger on interface methods #596

Closed
shmuelie opened this issue Jul 24, 2017 · 2 comments
Closed

Fix S3242: Rule should not trigger on interface methods #596

shmuelie opened this issue Jul 24, 2017 · 2 comments
Assignees
@michalb-sonar
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
6.4

Comments

@shmuelie
Copy link

While the usage in the method may allow for a more base type, since the interface requires the higher type triggering S3242 is invalid.
@Evangelink
Copy link
Contributor

Hi @SamuelEnglard !
Do you mean that we recommend to use a less derived type on a method parameter while this method is actually the implementation of an interface?

@shmuelie
Copy link
Author

@Evangelink yes

@Evangelink Evangelink added Type: False Positive Rule IS triggered when it shouldn't be. rules and removed question labels Jul 25, 2017
@Evangelink Evangelink added this to the 6.4 milestone Jul 25, 2017
@Evangelink Evangelink changed the title Rule S3242 should not trigger on interface methods Fix S3242: Rule should not trigger on interface methods Jul 25, 2017
@michalb-sonar michalb-sonar self-assigned this Aug 1, 2017
@michalb-sonar michalb-sonar mentioned this issue Aug 2, 2017
Merged
@michalb-sonar michalb-sonar reopened this Aug 3, 2017
@michalb-sonar michalb-sonar mentioned this issue Aug 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michalb-sonar michalb-sonar

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
6.4
Development

No branches or pull requests
4 participants
@shmuelie @Evangelink @valhristov @michalb-sonar