Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update S104: "Too many lines in a file" should only count lines of code #396

Closed
ganncamp opened this issue Jun 1, 2017 · 0 comments
Closed

Update S104: "Too many lines in a file" should only count lines of code #396

ganncamp opened this issue Jun 1, 2017 · 0 comments
Assignees
@Evangelink
Milestone
6.7

Comments

@ganncamp
Copy link

ganncamp commented Jun 1, 2017 •
edited by valhristov
Loading

Rule S104

The implementation of this rule should be adjusted to only take Lines of Code into account. This is part of MMF-571, and also falls under the Kill the Noise initiative.

Also: https://stackoverflow.com/questions/44315302/s104-sonarqube-is-it-possible-that-the-summary-or-comments-are-not-added-in
@valhristov valhristov changed the title Rule S104 (too many lines in a file) Adjust implementation to only count lines of code Update S104: "Too many lines in a file" Adjust implementation to only count lines of code Jun 2, 2017
@valhristov valhristov changed the title Update S104: "Too many lines in a file" Adjust implementation to only count lines of code Update S104: "Too many lines in a file" should only count lines of code Jun 2, 2017
@Evangelink Evangelink self-assigned this Nov 22, 2017
@Evangelink Evangelink added this to the 6.7 milestone Nov 22, 2017
@Evangelink Evangelink mentioned this issue Nov 22, 2017
Merged
@ghost ghost removed the Status: Needs Review label Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
None yet
Projects
None yet
Milestone
6.7
Development

No branches or pull requests
2 participants
@ganncamp @Evangelink