Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2701: rule should ignore bool? assertions #1874

Closed
valhristov opened this issue Sep 24, 2018 · 0 comments
Closed

Fix S2701: rule should ignore bool? assertions #1874

valhristov opened this issue Sep 24, 2018 · 0 comments
Assignees
@valhristov @loic-joly-sonarsource
Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Milestone
7.8

Comments

@valhristov
Copy link
Contributor

valhristov commented Sep 24, 2018 •
edited
Loading

Description

The following causes rule S2701 to fire:

        bool? x = false;
        Assert.AreEqual(false, x);

However, the suggested change fails to compile:

        Assert.IsFalse(x);

Original request: https://community.sonarsource.com/t/should-s2701-apply-to-bool-datatypes/2435
@valhristov valhristov added Type: False Positive Rule IS triggered when it shouldn't be. Area: Rules labels Sep 24, 2018
@valhristov valhristov added this to the Rules milestone Sep 24, 2018
@valhristov valhristov modified the milestones: Rules, 7.7 Oct 9, 2018
@loic-joly-sonarsource loic-joly-sonarsource self-assigned this Oct 15, 2018
Merged
@valhristov valhristov mentioned this issue Oct 23, 2018
Merged
@ghost ghost assigned valhristov Oct 23, 2018
@ghost ghost removed the Status: Needs Review label Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valhristov valhristov

@loic-joly-sonarsource loic-joly-sonarsource

Labels
Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
7.8
Development

No branches or pull requests
2 participants
@valhristov @loic-joly-sonarsource