Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CxxVCppBuildLogParser does not detect absolute path #711

Closed
Bertk opened this issue Dec 13, 2015 · 4 comments
Closed

CxxVCppBuildLogParser does not detect absolute path #711

Bertk opened this issue Dec 13, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@Bertk
Copy link
Contributor

Bertk commented Dec 13, 2015

The VC++ log file parser adds wrong paths and a warning message is created like " WARN - the include root 'd:\dir1\dir2\dir3\project-dir\dir1\dir2\dir3\include' doesnt exist'.
The VC++ log file has include folder definitions like /I\dir1\dir2\dir3\include without the windows drive letter information and this is not handled correctly. The windows drive letter information is removed by intention because users might configure the ClearCase views differently.

@Bertk Bertk added the bug label Dec 13, 2015
@guwirth guwirth added this to the M 0.9.5 milestone Feb 20, 2016
@jmecosta jmecosta self-assigned this Mar 13, 2016
@jmecosta
Copy link
Member

i will handle this one

@jmecosta
Copy link
Member

@Bertk this is fixed already, right?

      File includeRoot = new File(element.replace("\"", ""));
      String includePath;
      Path p = Paths.get(project);
      if (!includeRoot.isAbsolute()) {
        // handle path without drive information but represent absolute path
        File pseudoAbsolute = new File(p.getRoot().toString(), includeRoot.toString());
        if (pseudoAbsolute.exists()) {
          includeRoot = new File(p.getRoot().toString(), includeRoot.getPath());
        } else {
          includeRoot = new File(project, includeRoot.getPath());
        }
      }

@jmecosta
Copy link
Member

handle here #744

@Bertk
Copy link
Contributor Author

Bertk commented Mar 13, 2016

Yes, this is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants