We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Bertk: Yes, we should use more Java 7 methods and replace this Strings class with Path class. I also feel we should remove dependency to org.apache.commons.io.FilenameUtils in CxxReportSensor.java and use java.nio.file.path. https://docs.oracle.com/javase/tutorial/essential/io/pathOps.html https://docs.oracle.com/javase/8/docs/api/java/nio/file/Path.html
The text was updated successfully, but these errors were encountered:
@Bertk: What is the advantage?
Sorry, something went wrong.
Currently we use strings for paths and file names. Java 7 has a rich feature set for file&path and especially the relativize method (http://docs.oracle.com/javase/7/docs/api/java/nio/file/Path.html#relativize(java.nio.file.Path) which is helpful for the sensors. I expect some cleaner code and we should use nio methods or SQ InputFile in org.sonar.plugins.cxx.utils.
I also want to investigate a problem with CppCheck sensor which did not create issues for sources in sub-folders.
#683 should use nio lib
@Bertk why did you close this? I still found some places where org.apache.commons.io.FileUtils is in use?
org.apache.commons.io.FileUtils
https://github.com/SonarOpenCommunity/sonar-cxx/search?utf8=%E2%9C%93&q=org.apache.commons.io.FileUtils&type=
No branches or pull requests
@Bertk: Yes, we should use more Java 7 methods and replace this Strings class with Path class. I also feel we should remove dependency to org.apache.commons.io.FilenameUtils in CxxReportSensor.java and use java.nio.file.path.
https://docs.oracle.com/javase/tutorial/essential/io/pathOps.html
https://docs.oracle.com/javase/8/docs/api/java/nio/file/Path.html
The text was updated successfully, but these errors were encountered: